-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement riscv_vlen_asm for riscv32 #24270
Closed
ZenithalHourlyRate
wants to merge
1
commit into
openssl:master
from
ZenithalHourlyRate:riscv32-fix-compiling
Closed
Implement riscv_vlen_asm for riscv32 #24270
ZenithalHourlyRate
wants to merge
1
commit into
openssl:master
from
ZenithalHourlyRate:riscv32-fix-compiling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riscvcap.c: undefined reference to 'riscv_vlen_asm'
github-actions
bot
added
the
severity: fips change
The pull request changes FIPS provider sources
label
Apr 26, 2024
t8m
added
branch: master
Merge to master branch
approval: review pending
This pull request needs review by a committer
approval: otc review pending
This pull request needs review by an OTC member
triaged: bug
The issue/pr is/fixes a bug
severity: regression
The issue/pr is a regression from previous released version
tests: exempted
The PR is exempt from requirements for testing
branch: 3.3
Merge to openssl-3.3
labels
Apr 26, 2024
t8m
approved these changes
Apr 26, 2024
t8m
removed
the
approval: otc review pending
This pull request needs review by an OTC member
label
Apr 26, 2024
shahsb
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Wonder if anything should be done for this PR |
ping @openssl/committers for second review |
paulidale
approved these changes
May 8, 2024
paulidale
added
approval: done
This pull request has the required number of approvals
and removed
approval: review pending
This pull request needs review by a committer
labels
May 8, 2024
openssl-machine
added
approval: ready to merge
The 24 hour grace period has passed, ready to merge
and removed
approval: done
This pull request has the required number of approvals
labels
May 9, 2024
This pull request is ready to merge |
Merged to the master and 3.3 branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
May 10, 2024
riscvcap.c: undefined reference to 'riscv_vlen_asm' Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #24270)
jvdsn
pushed a commit
to jvdsn/openssl
that referenced
this pull request
Jun 3, 2024
riscvcap.c: undefined reference to 'riscv_vlen_asm' Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#24270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approval: ready to merge
The 24 hour grace period has passed, ready to merge
branch: master
Merge to master branch
branch: 3.3
Merge to openssl-3.3
severity: fips change
The pull request changes FIPS provider sources
severity: regression
The issue/pr is a regression from previous released version
tests: exempted
The PR is exempt from requirements for testing
triaged: bug
The issue/pr is/fixes a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now for the linux32-riscv32 target, we would get the error when linking
#20149 added
riscv_vlen_asm
inriscv64cpuid.pl
but not inriscv32cpuid.pl
, and this function is needed inriscvcap.c
.Checklist